6789 git-sync volume support #556
Conversation
…de. Breakout logic into function.
| ## the git-sync-relay | ||
| volumeSync: | ||
| volumeSize: 10Gi | ||
| # The specified storageClassName must support ReadWriteMany |
There was a problem hiding this comment.
ReadWriteMany should this comment be removed in here
There was a problem hiding this comment.
That is a hint to the user. Actually, we have not been following the recommendations for documentation in helm charts, so maybe this is something we should improve? https://v2.helm.sh/docs/chart_best_practices/#document-values-yaml
There was a problem hiding this comment.
shall we remove the hard requirement of # The specified storageClassName must support ReadWriteMany
|
@danielhoherd are we proceeding with the readwrite once new approach right in that case we should add code refactoring at api level rest of the changes in chart looks fine |
|
@pgvishnuram no, that is not the same feature. This is a feature that allows git-sync-relay to sync the git repo over a shared volume. The feature you're talking about is a feature that moves the git-sync-relay to durable storage while keeping daemon mode. |
Description
Add git-sync volume mode.
Related Issues
Testing
I've tested this manually. We'll need more comprehensive testing from QA since this is a new feature that will have astro-ui and houston components.
Merging
This is only meant for 0.37